Remove custom Bosch pi_heating_demand attr for RBSH-RTH0-ZB-EU
#4329
Conversation
due to conflicting with thermostat cooling mode. Fixes home-assistant/core#151763. This thermostat reports correct status through system_mode and running_mode attributes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4329 +/- ##
==========================================
- Coverage 92.13% 92.12% -0.01%
==========================================
Files 358 358
Lines 11919 11917 -2
==========================================
- Hits 10981 10979 -2
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think it's a good idea to remove the sensor altogether. It's useful information. |
TheJulianJES
added
bugfix
|
@Sopsy I would restore previous cooling related functionality until your patch is ready. |
I'm not against it, especially if this one can be merged quickly (easy to review) and thus fixing the bug sooner. However my patch is already ready from what I can do right now. The further commits I made after opening the pull request were features I found while probing the thermostat and I thought it's a good idea to include them as well to benefit everyone right away. They were features I was sorely missing after ditching the SHC. Of the four things mentioned in additional details, there is one that I'd really want to still fix, but that can be a second patch later down the road. Namely the heater type config is still missing and I'd love to have it supported as well. There is some discussion about it in Koenkk/zigbee-herdsman-converters#9662 |
TheJulianJES
changed the title
pi_heating_demand attribute for RBSH-RTH0-ZB-EU
|
I'll take a look at the other PR as soon as possible. For now, we can merge this. |
TheJulianJES
changed the title
pi_heating_demand attribute for RBSH-RTH0-ZB-EUpi_heating_demand attr for RBSH-RTH0-ZB-EU
Proposed change
Remove custom Bosch pi_heating_demand attribute for RBSH-RTH0-ZB-EU due to conflicting with thermostat cooling mode.
Fixes home-assistant/core#151763.
This thermostat reports correct status through system_mode and running_mode attributes.
Checklist
pre-commitchecks pass / the code has been formatted using Black